Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChibiOS: add support for HID Programmable Buttons #15787

Merged
merged 2 commits into from Feb 4, 2022
Merged

ChibiOS: add support for HID Programmable Buttons #15787

merged 2 commits into from Feb 4, 2022

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Jan 8, 2022

Description

This adds support for HID Programmable Buttons for ChibiOS devices.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 8, 2022
@t-8ch
Enable SHARED_ENDPOINT when PROGRAMMABLE_BUTTON is enabled
a849d7c 
The Programmable Button driver expects the shared EP to be enabled.
So enforce this invariant.
@tzarc tzarc requested review from drashna, sigprof and a team February 4, 2022 18:44
@zvecr zvecr merged commit f1cd2a5 into qmk:develop Feb 4, 2022
@t-8ch t-8ch deleted the chibios-programmable-button branch February 5, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

@drashna drashna Awaiting requested review from drashna

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@t-8ch @sigprof @drashna @tzarc @zvecr