-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
[Core] Allow usage of ChibiOS's SIO driver for split keyboards #15907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
f520d21 to
93b8c44
Compare
93b8c44 to
4264889
Compare
4264889 to
9a35d33
Compare
9a35d33 to
b866354
Compare
b866354 to
e00275d
Compare
e00275d to
f5ea35b
Compare
|
Updated the docs, this is now ready to be reviewed. |
0ebcbbf to
cd1da64
Compare
|
@daskygit as you use G4s on a crkbd could you help verifying that the |
cd1da64 to
80122f2
Compare
80122f2 to
2c04248
Compare
daskygit
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some troubleshooting on Discord with Karl it's working well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build upon #16647 while this one is not merged please ignore the commit Use a mutex for split shared memory synchronization in this PR.
Description
Allow usage of 21.11+ ChibiOS's SIO driver for split keyboards. The cool thing about the SERIAL and SIO driver is that both implement the
BaseChannelinterface that provides blocking reading and writing methods that resemble what we already use in the driver. Only some low level aspects like initialization have to be handled differently.Supported Hardware (incomplete)
Every STM32 MCU family that supports
USARTv2orUSARTv3like:For test-driving these changes do the following:
config.h
halconf.h
mcuconf.h
Target use-case is the RP2040 which only implements this driver at this point.
Types of Changes
Issues Fixed or Closed by This PR
Checklist