Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB Matrix: Reload from EEPROM #15923

Merged
merged 3 commits into from Feb 5, 2022
Merged

RGB Matrix: Reload from EEPROM #15923

merged 3 commits into from Feb 5, 2022

Conversation

lickel
Copy link
Contributor

@lickel lickel commented Jan 18, 2022

Description

This adds a a trivial rgb_matrix_reload_from_eeprom() implementation drawing heavily from the equivalent rgblight_reload_from_eeprom().

It is cherry-picked from #15922

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

sigprof
sigprof requested changes Jan 18, 2022
View reviewed changes
quantum/rgb_matrix/rgb_matrix.c Outdated Show resolved Hide resolved
@lickel lickel mentioned this pull request Jan 18, 2022
Merged
14 tasks
@lickel @sigprof
Update quantum/rgb_matrix/rgb_matrix.c
d37bfef 
Review suggestion

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@lickel lickel requested a review from sigprof January 18, 2022 17:16
0xcharly
0xcharly approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@0xcharly 0xcharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just looking for something like this. Thanks for taking the time to create the PR!

I tried that locally, and I can confirm that it's behaving as (what I) expected.

@lickel
Copy link
Contributor Author

lickel commented Jan 31, 2022

@sigprof bump

@lickel @sigprof
Update quantum/rgb_matrix/rgb_matrix.c
e8a9f69 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
@lickel lickel requested a review from sigprof January 31, 2022 20:41
@lickel
Copy link
Contributor Author

lickel commented Feb 2, 2022

@sigprof are you able to merge? Or is there someone else I could poke?

@drashna drashna merged commit eb8ace0 into qmk:develop Feb 5, 2022
@lickel lickel deleted the rgb_matrix_reload branch February 5, 2022 03:09
0xcharly pushed a commit to 0xcharly/qmk_firmware that referenced this pull request Feb 6, 2022
@lickel @0xcharly
RGB Matrix: Reload from EEPROM (qmk#15923)
f33f7e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof sigprof approved these changes

@drashna drashna drashna approved these changes

@0xcharly 0xcharly 0xcharly approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lickel @sigprof @drashna @0xcharly