Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align location of some host led logic #15954

Merged
merged 6 commits into from Jan 22, 2022
Merged

Align location of some host led logic #15954

merged 6 commits into from Jan 22, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 20, 2022 •
edited

Description

  • Almost all host LED code now in one location
  • Remove keyboard_set_leds as it was mostly irrelevant to the new location
  • Minor tidy up

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 20, 2022 19:16
@zvecr zvecr changed the title Align location of host led logic Align location of some host led logic Jan 20, 2022
drashna
drashna approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and doesn't seem to break host leds.

@drashna drashna requested a review from a team January 22, 2022 04:44
@zvecr zvecr merged commit 6e83b44 into qmk:develop Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @drashna