Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script that simplifies running commands under docker. #16028

Merged
merged 1 commit into from Jan 24, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 24, 2022

Description

Newer versions of clang-format produce different output compared to what's in the container.
Given that CI runs in the container, needed a simpler method of executing against the "blessed" version.

This adds a new command, util/docker_cmd.sh, which effectively just executes whatever arguments you pass to the script as another command, but inside the container.

Basically a dupe of util/docker_build.sh.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team January 24, 2022 22:37
@github-actions github-actions bot added the core label Jan 24, 2022
@zvecr zvecr merged commit 5f23345 into qmk:develop Jan 24, 2022
@tzarc tzarc deleted the add-docker-runner-script branch January 25, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants