Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Q-series on the ckled2001 LED driver #16051

Merged
merged 1 commit into from Jan 30, 2022

Conversation

vinorodrigues
Copy link
Contributor

Description

This PR adds a slight alteration of the Keychron CKLED2001 led driver initialisation code in core where in the Keychron Q-series keyboards require the initialization bit to be set to 0xA0 instead of 0xFF on certain tune lengths (as implemented in the working copy of the Q-series hosted on the keychron/qmk_firmware:playground repo, and a follow up of PR #14872).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 26, 2022
@drashna drashna requested a review from a team January 29, 2022 19:10
@drashna drashna merged commit cad8866 into qmk:develop Jan 30, 2022
@vinorodrigues vinorodrigues deleted the vr-keychron-ckled2001-qs branch January 30, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants