Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layout change callbacks to VIA #16087

Merged
merged 2 commits into from Feb 6, 2022
Merged

Add layout change callbacks to VIA #16087

merged 2 commits into from Feb 6, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 27, 2022

Description

Provides a way for keyboards to get the layout options, without having to constantly querying the eeprom. what/how to implement that is left up to users.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 27, 2022 21:05
@zvecr zvecr merged commit 9124f5d into qmk:develop Feb 6, 2022
@drashna drashna deleted the via/callbacks branch February 7, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drashna @zvecr