Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move niu_mini to /kbdfans #16112

Merged
merged 1 commit into from Feb 1, 2022
Merged

move niu_mini to /kbdfans #16112

merged 1 commit into from Feb 1, 2022

Conversation

peepeetee
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 29, 2022
@peepeetee peepeetee mentioned this pull request Jan 29, 2022
Closed
@drashna drashna requested a review from a team January 31, 2022 19:51
@drashna drashna merged commit 1477440 into qmk:develop Feb 1, 2022
@tzarc
Copy link
Member

tzarc commented Feb 1, 2022

This PR breaks CI's testing:

lib/python/qmk/tests/test_cli_commands.py
116:    result = check_subcommand('list-keymaps', '-kb', 'niu_mini')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peepeetee @tzarc @drashna @fauxpark