Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup multibuild filegen #16166

Merged
merged 2 commits into from Feb 2, 2022
Merged

Fixup multibuild filegen #16166

merged 2 commits into from Feb 2, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 2, 2022

Description

Moves the creation of version.h into a keyboard-specific location, so that parallel builds don't obliterate each other.
Also fixes up qmk multibuild to allow for -e SKIP_VERSION=yes and the like to be added, much like qmk compile already does.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Feb 2, 2022
@tzarc tzarc requested a review from a team February 2, 2022 04:21
@github-actions github-actions bot added cli qmk cli command core python labels Feb 2, 2022
drashna
drashna approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works for me, so LGTM.

@drashna drashna requested a review from a team February 2, 2022 04:25
@fauxpark
Copy link
Member

fauxpark commented Feb 2, 2022

Should kill off the gitignore entry too.

@tzarc tzarc merged commit 6e2b03c into qmk:develop Feb 2, 2022
@tzarc tzarc deleted the fixup-multibuild-filegen branch February 2, 2022 04:30
@tzarc
Copy link
Member Author

tzarc commented Feb 2, 2022

Should kill off the gitignore entry too.

Good point, will fix it up with a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command core python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzarc @fauxpark @drashna