Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outputselect to use platform connected state API #16185

Merged
merged 1 commit into from Feb 4, 2022
Merged

Update outputselect to use platform connected state API #16185

merged 1 commit into from Feb 4, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 3, 2022 •
edited

Description

Removes platform ifdefs, which in turn removes the need for some of the proposed changes in #15947

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from fauxpark and a team February 3, 2022 13:10
@github-actions github-actions bot added the core label Feb 3, 2022
@dexter93
Copy link
Contributor

dexter93 commented Feb 3, 2022

yes please 👍

@drashna drashna merged commit 8927d56 into qmk:develop Feb 4, 2022
@dexter93 dexter93 mentioned this pull request Feb 4, 2022
Closed
14 tasks
1Conan pushed a commit to 1Conan/qmk_firmware that referenced this pull request Feb 6, 2022
@zvecr @1Conan
Update outputselect to use platform connected state API (qmk#16185)
e293ff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zvecr @dexter93 @tzarc @fauxpark @drashna