Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc size regression script improvements. #16268

Merged
merged 2 commits into from Feb 8, 2022
Merged

Misc size regression script improvements. #16268

merged 2 commits into from Feb 8, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 7, 2022

Description

  • Sets environment variable SIZE_REGRESSION_EXECUTING during execution
    so hook scripts like post-checkout may skip processing.
  • Forces checkout of the target branch, including removal of all
    temporary object files in the process.
  • Prints out a warning on exit stating that the git repository is in an
    indeterminate state, and the user needs to swap back to whatever
    intended branch they were working with originally.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Misc size regression script improvements.
7be6247 
- Sets environment variable SIZE_REGRESSION_EXECUTING during execution
  so hook scripts like `post-checkout` may skip processing.
- Forces checkout of the target branch, including removal of all
  temporary object files in the process.
- Prints out a warning on exit stating that the git repository is in an
  indeterminate state, and the user needs to swap back to whatever
  intended branch they were working with originally.
@tzarc tzarc requested a review from a team February 7, 2022 21:06
@github-actions github-actions bot added the core label Feb 7, 2022
KarlK90
KarlK90 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zvecr
zvecr reviewed Feb 8, 2022
View reviewed changes
util/size_regression.sh Outdated Show resolved Hide resolved
@zvecr zvecr merged commit a239051 into qmk:develop Feb 8, 2022
@zvecr
Copy link
Member

zvecr commented Feb 8, 2022

Maybe the git clean part could be hidden behind a -f argument?

@tzarc tzarc deleted the size-regression-detection branch February 8, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark fauxpark approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tzarc @zvecr @fauxpark @KarlK90