Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent-relative paths from keyboards. #16282

Merged
merged 2 commits into from Feb 9, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 9, 2022

Description

Cleanup, relative paths were being defined in a few keyboards, messing with the relative locations in .build/ during build.

In one case, CI was showing issues with intermediate files being removed due to multiple boards from the same manufacturer resulting in the same output file.

For example, rgbkb/sol3 and rgbkb/mun were both targeting:

.build/obj_rgbkb_sol3_rev1/../common/touch_encoder.o   =>   .build/common/touch_encoder.o
.build/obj_rgbkb_mun_rev1/../common/touch_encoder.o    =>   .build/common/touch_encoder.o

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Feb 9, 2022
@tzarc tzarc requested a review from a team February 9, 2022 09:38
@Erovia Erovia requested a review from a team February 9, 2022 10:30
keyboards/capsunlocked/cu75/rules.mk Outdated Show resolved Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
@tzarc tzarc merged commit c2c2f30 into qmk:develop Feb 9, 2022
@tzarc tzarc deleted the remove-parent-relative-paths branch February 9, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants