Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size checks print out target firmware file instead #16290

Merged
merged 1 commit into from Feb 9, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 9, 2022

Description

There's been a few instances of people trying to flash the hex file listed during size checks, rather than the output firmware in the root directory. This is problematic for ARM builds, as they'll generally be in BIN format -- the output still lists the HEX path.

Old:
image

New:
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team February 9, 2022 21:01
@github-actions github-actions bot added the core label Feb 9, 2022
@tzarc tzarc force-pushed the fixup-firmware-output-size-confusion branch from bb8734e to 3221196 Compare February 9, 2022 21:05
@tzarc tzarc merged commit ae6f471 into qmk:develop Feb 9, 2022
@tzarc tzarc deleted the fixup-firmware-output-size-confusion branch February 9, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants