Heatmap incorrect matrix effect workaround #16315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peepeetee
approved these changes
Feb 11, 2022
filterpaper
force-pushed
the
heatmap-stopgap
branch
from
01e966b to
7df0595
Compare
drashna
approved these changes
Mar 8, 2022
KarlK90
approved these changes
Apr 15, 2022
drashna
approved these changes
Apr 16, 2022
|
Thanks! |
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a simple override to limit heatmap effect to pressed keys. It is a stop gap workaround of incorrect columns and rows lighting for non-rectangle key matrix. (And reformatted both paragraphs in the heatmap section)
Types of Changes
Checklist