Skip to content

[Core] Move has_mouse_report_changed function to report.c #16543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2022
Merged

[Core] Move has_mouse_report_changed function to report.c #16543

merged 3 commits into from
Mar 14, 2022
+32 −23

Conversation

drashna
Copy link
Member

@drashna drashna commented Mar 6, 2022 •
edited
Loading

Description

Moves has_mouse_report_changed function to report.c, as both pointing device and mousekeys check for changes to the report to determine if to send or not.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team March 6, 2022 01:02
@github-actions github-actions bot added the core label Mar 6, 2022
@drashna drashna changed the title Core/mouse reports [Core] Move has_mouse_report_changed function to report.c` Mar 7, 2022
@drashna drashna changed the title [Core] Move has_mouse_report_changed function to report.c` [Core] Move has_mouse_report_changed function to report.c` Mar 7, 2022
@drashna drashna changed the title [Core] Move has_mouse_report_changed function to report.c` [Core] Move has_mouse_report_changed function to report.c Mar 7, 2022
@drashna drashna force-pushed the core/mouse_reports branch from 6d86439 to 549c8f6 Compare March 8, 2022 04:27
@zvecr zvecr merged commit 921b9da into qmk:develop Mar 14, 2022
@waffle87 waffle87 mentioned this pull request Mar 14, 2022
Merged
9 tasks
@drashna drashna deleted the core/mouse_reports branch March 14, 2022 01:54
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@drashna @zykrah
[Core] Move has_mouse_report_changed function to report.c (qmk#16543
2aa97c5 
)

* Move 'has_mouse_report_changed' checkto report.c

* change mousekeys to use memcpy

* fix linting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @zvecr