Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Move has_mouse_report_changed function to report.c #16543

Merged
merged 3 commits into from Mar 14, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Mar 6, 2022

Description

Moves has_mouse_report_changed function to report.c, as both pointing device and mousekeys check for changes to the report to determine if to send or not.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team March 6, 2022 01:02
@github-actions github-actions bot added the core label Mar 6, 2022
@drashna drashna changed the title Core/mouse reports [Core] Move has_mouse_report_changed function to report.c` Mar 7, 2022
@drashna drashna changed the title [Core] Move has_mouse_report_changed function to report.c` [Core] Move has_mouse_report_changed function to report.c` Mar 7, 2022
@drashna drashna changed the title [Core] Move has_mouse_report_changed function to report.c` [Core] Move has_mouse_report_changed function to report.c Mar 7, 2022
@zvecr zvecr merged commit 921b9da into qmk:develop Mar 14, 2022
@waffle87 waffle87 mentioned this pull request Mar 14, 2022
9 tasks
@drashna drashna deleted the core/mouse_reports branch March 14, 2022 01:54
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Mar 14, 2022
* qmk/develop: (696 commits)
  Sentence correction (qmk#16650)
  [Keyboard] Add via keymap to AL1 (qmk#16499)
  Rename TICK to TICK_EVENT to prevent naming conflicts (qmk#16649)
  [Keyboard] Add BAMFK-1 (qmk#16409)
  Disable RGB matrix pixel animations for some boards (qmk#16643)
  keebio/iris: Add ifdefs to encoder callbacks (qmk#16642)
  bolsa/damapad - Fix missing layout macro (qmk#16639)
  Mousekeys fix (qmk#16640)
  Fix oneshot toggle logic (qmk#16630)
  Fix 40percentclub USB descriptors (qmk#16638)
  [Core] Move `has_mouse_report_changed` function to `report.c`  (qmk#16543)
  ISP flashing guide: add instructions for flashing STM32duino bootloader (qmk#16568)
  Move keyboard USB IDs and strings to data driven: 0-9 (qmk#16481)
  USB-USB converter cleanup (qmk#16618)
  [Keyboard] Add "Uno" rev2 (qmk#14071)
  [Keyboard] Add support for Jels60 (qmk#16605)
  helix:edvorakjp keymap change to use split_common (qmk#16532)
  [Keymap] Update personal crkbd keymap (qmk#16624)
  [Keyboard] add missing endif in glitch keyboard (qmk#16629)
  [Keyboard] Add damapad (qmk#16443)
  ...
tim-bennett83 pushed a commit to tim-bennett83/qmk_firmware that referenced this pull request Jun 15, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
)

* Move 'has_mouse_report_changed' checkto report.c

* change mousekeys to use memcpy

* fix linting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants