Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non blackpill F4x1 config files #16600

Merged
merged 5 commits into from Apr 6, 2022
Merged

Add non blackpill F4x1 config files #16600

merged 5 commits into from Apr 6, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 9, 2022 •
edited

Description

Add better defaults - 8MHz HSE

TODO:

  • rework f401 i2c bodge
  • use defaults from bonsai/stemcell PRs?

Future

  • Closer to develop merge - swap existing blackpill boards over
    * Add BOARD = BLACKPILL_....
    * MCU = STM32F401 to default to BOARD = GENERIC_STM32_F401XC
    * MCU = STM32F411 to default to BOARD = GENERIC_STM32_F411XE

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 9, 2022
@zvecr zvecr requested review from tzarc and a team March 9, 2022 21:33
@drashna drashna requested a review from a team March 9, 2022 21:36
@zvecr zvecr requested a review from tzarc March 14, 2022 00:30
@zvecr zvecr merged commit a5e810b into qmk:develop Apr 6, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @zykrah
Add non blackpill F4x1 config files (qmk#16600)
7795f1b 
* Add non blackpill F4x1 config files

* Move ld files

* Remove f401 i2c bodges

* more bodge?

* Update to recommended defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zvecr @drashna @tzarc @fauxpark