Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CTPC logic to allow future converters #16621

Merged
merged 2 commits into from Apr 3, 2022
Merged

Refactor CTPC logic to allow future converters #16621

merged 2 commits into from Apr 3, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 11, 2022 •
edited

Description

Cherry picked whats ready to go from #16598.

This PR aims to...

  • Infer more when processing converters
    • Should start to flesh out the interface for future converters
  • Avoid some converter specific logic in core platform files
    • Pin definitions are now isolated to each converter
  • Maintain existing behaviour of CTPC
    • Everything is still considered a conversion target

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team March 11, 2022 20:38
@github-actions github-actions bot added the core label Mar 11, 2022
Erovia
Erovia approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak))

@Erovia Erovia requested a review from a team March 11, 2022 20:42
KarlK90
KarlK90 approved these changes Mar 18, 2022
View reviewed changes
builddefs/converters.mk Outdated Show resolved Hide resolved
@zvecr @KarlK90
Update builddefs/converters.mk
17d157f 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
@zvecr zvecr merged commit 1660b2d into qmk:develop Apr 3, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @KarlK90 @zykrah
Refactor CTPC logic to allow future converters (qmk#16621)
9be0310 
* Refactor CTPC logic to allow future converters

* Update builddefs/converters.mk

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>

Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @Erovia @KarlK90