Fix oneshot toggle logic #16630
Merged
Fix oneshot toggle logic #16630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Mar 13, 2022
|
Honestly, I'd prefer a lighter touch, but fixing the function created some very convoluted logic. And just made it harder to read. we could go with that, but I think this would be more maintainable then negatives and double negatives, etc. |
drashna
force-pushed
the
fix/oneshot_mods
branch
from
ff68993 to
b728610
Compare
|
You would also need to bump the eeprom version given the value is now inverted. |
zvecr
approved these changes
Mar 13, 2022
fauxpark
approved these changes
Mar 14, 2022
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
* Fix oneshot toggle logic * Enable oneshots by default * Decrement eeconfig magic number due to eeconfig changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#16617 tried to fix the bug, but honestly made it more convoluted, and broke it further.
This changes the variable name and simplifies the logic, so it's clear and concise.
Types of Changes
Issues Fixed or Closed by This PR
Checklist