Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore transport defaults if SPLIT_KEYBOARD is unset #16706

Merged
merged 2 commits into from Mar 22, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 21, 2022

Description

No real point in providing a chunk of the split config, on non split keyboards

 qmk info -f json -kb xd84 | grep -A2 split
    "split": {
        "transport": {
            "protocol": "serial"

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 21, 2022
@zvecr zvecr requested a review from a team March 21, 2022 23:53
@github-actions github-actions bot added cli qmk cli command python labels Mar 21, 2022
@drashna drashna requested a review from a team March 21, 2022 23:58
@zvecr zvecr merged commit 23f365f into qmk:develop Mar 22, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
* Ignore transport defaults if SPLIT_KEYBOARD is unset

* keep exists check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants