Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to change the pwm frequency for the IS31FL3737B #16718

Merged
merged 1 commit into from Mar 24, 2022
Merged

add the ability to change the pwm frequency for the IS31FL3737B #16718

merged 1 commit into from Mar 24, 2022

Conversation

Frooastside
Copy link

@Frooastside Frooastside commented Mar 23, 2022

Description

I made the same changes to support changing the PWM frequency with the IS31FL3737B and no longer just the IS31FL3733B.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Frooastside
Copy link
Author

Frooastside commented Mar 23, 2022

I don't really know if this is a core change and instead should target the develop branch, but it is definetly not a breaking change.

@zvecr
Copy link
Member

zvecr commented Mar 24, 2022

if this is a core change and instead should target the develop branch

It would be considered core, and we generally want those to go via develop. It could go directly to master as it should be backwards compatible, though this wouldnt be my preference. I will leave that open to other collabs.

@zvecr zvecr requested a review from a team March 24, 2022 15:10
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I would prefer that this go to develop, and through the normal breaking changes cycle.

Mostly, because it's a slippery slope. If it's a small change, and we let it through, how big of a change does it have to be? Etc.

The policy has been that bugfixes are okay to go to master, directly. Eg, stuff that breaks compiling altogether, or breaks behavior.

@Frooastside
Copy link
Author

Frooastside commented Mar 24, 2022

As i said I wasn't sure if it is a core change, now I am. Should I change it to target the develop branch instead?

@Frooastside Frooastside changed the base branch from master to develop March 24, 2022 17:58
@zvecr zvecr merged commit dc9eb21 into qmk:develop Mar 24, 2022
@Frooastside Frooastside deleted the is31fl3737b-pwm-frequency branch March 24, 2022 22:29
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants