Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for CTPC/CONVERT_TO_PROTON_C. #16782

Merged
merged 1 commit into from Apr 3, 2022
Merged

Add warning for CTPC/CONVERT_TO_PROTON_C. #16782

merged 1 commit into from Apr 3, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 3, 2022

Description

Adds a build-time warning for CTCP/CONVERT_TO_PROTON_C -- stating the new syntax.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from zvecr and a team April 3, 2022 18:01
@noroadsleft noroadsleft changed the title Add warning for CTCP/CONVERT_TO_PROTON_C. Add warning for CTPC/CONVERT_TO_PROTON_C. Apr 3, 2022
@drashna drashna requested a review from a team April 3, 2022 18:15
@zvecr zvecr merged commit ec4f655 into qmk:develop Apr 3, 2022
@tzarc tzarc deleted the warn-on-ctpc branch April 3, 2022 20:49
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@tzarc @zykrah
Add warning for CTCP/CONVERT_TO_PROTON_C. (qmk#16782)
a35cdad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzarc @drashna @zvecr