Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement XAP 'secure' core requirements #16843

Merged
merged 9 commits into from
Apr 16, 2022
Merged

Implement XAP 'secure' core requirements #16843

merged 9 commits into from
Apr 16, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 12, 2022 •
edited
Loading

Description

Cherry picked from #13733.

The core of the XAP secure functionality is generic enough to be its own feature, and could have reuse outside of the current XAP use cases.

General name is still up for grabs, as "secure" might imply more security than the feature actually provides.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the base branch from master to develop April 12, 2022 15:42
@github-actions github-actions bot added cli qmk cli command core python labels Apr 12, 2022
@zvecr zvecr changed the title Feature/secure Implement XAP 'secure' core requirements Apr 12, 2022
@zvecr zvecr requested a review from a team April 12, 2022 15:44
@drashna drashna requested a review from a team April 13, 2022 08:27
@drashna drashna requested review from drashna and a team April 13, 2022 08:44
@zvecr @drashna
Update quantum/process_keycode/process_secure.c
bc21bd4 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team April 14, 2022 16:01
KarlK90
KarlK90 approved these changes Apr 14, 2022
View reviewed changes
builddefs/generic_features.mk Show resolved Hide resolved
quantum/secure.c Outdated Show resolved Hide resolved
zvecr and others added 3 commits April 14, 2022 21:01
@zvecr @KarlK90
Update quantum/secure.c
6610cef 
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
@zvecr
format
9a2b5af
@zvecr
show_options
74fc148
@drashna drashna requested a review from a team April 16, 2022 17:41
@drashna drashna merged commit 92a61aa into qmk:develop Apr 16, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @drashna
@KarlK90 @zykrah
Implement XAP 'secure' core requirements (qmk#16843)
817f546 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Stefan Kerkmann <karlk90@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core in progress needs doc python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @KarlK90