Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some layout exceptions #16957

Merged
merged 4 commits into from Apr 29, 2022
Merged

Remove some layout exceptions #16957

merged 4 commits into from Apr 29, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 28, 2022 •
edited

Description

Slowly getting rid of the exceptions, with the end goal of LAYOUT or regex.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 28, 2022
@zvecr zvecr requested a review from a team April 28, 2022 19:44
@zvecr zvecr marked this pull request as ready for review April 28, 2022 19:44
@drashna drashna requested a review from a team April 28, 2022 19:53
@zvecr zvecr merged commit 6e81994 into qmk:develop Apr 29, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @zykrah
Remove some layout exceptions (qmk#16957)
51b13a9 
* LAYOUT_JP -> LAYOUT_jp

* LAYOUT_ANSI_DEFAULT -> LAYOUT

* LAYOUT_reviung34_2uL -> LAYOUT_reviung34_2u
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @fauxpark