improvements for Cirque Pinnacle trackpads #17091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriechi
force-pushed
the
cirque-pinnacle-improvements
branch
2 times, most recently
from
79d6f24 to
8d2cda6
Compare
14 tasks
dkao
reviewed
May 15, 2022
Kriechi
force-pushed
the
cirque-pinnacle-improvements
branch
2 times, most recently
from
c5df4fb to
7f2caa7
Compare
dkao
reviewed
May 16, 2022
dkao
reviewed
May 16, 2022
Kriechi
force-pushed
the
cirque-pinnacle-improvements
branch
from
948cd56 to
c1cf2e8
Compare
dkao
approved these changes
May 17, 2022
drashna
approved these changes
May 20, 2022
* read Software Data Ready bit before actually reading data to avoid useless work * throttle data feed to 10ms by default, which is the fastest that Pinnacle supports * set RESET for Pinnacle on QMK pointing device driver init * first step towards relative mode (only data parsing for now) * cleanup unused register values when in absolute mode * added code comments and bit definitions for all registers and config options
only partially implemented so far
Kriechi
force-pushed
the
cirque-pinnacle-improvements
branch
from
c1cf2e8 to
afab84c
Compare
KarlK90
requested changes
Jun 23, 2022
dkao
suggested changes
Jun 23, 2022
Kriechi
force-pushed
the
cirque-pinnacle-improvements
branch
from
78a44ea to
dfb491b
Compare
|
@Kriechi thanks for addressing the review comments so fast, one point is left for me but other than that this is ready to go in. |
|
Also addressed now - thanks! |
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Checklist