Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup pimoroni trackball #17335

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fixup pimoroni trackball #17335

merged 1 commit into from
Jun 9, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Jun 9, 2022 •
edited
Loading

Description

Pretty sure #16371 just forgot to remove this function, as it was moved to quantum/pointing_device_drivers.c

Types of Changes

  • Core

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 9, 2022
@daskygit
Copy link
Member

daskygit commented Jun 9, 2022

So this was the result of a revert in the previous PR, I wonder if the intention was to keep a modified function in pimoroni_trackball.c.

@daskygit daskygit requested a review from drashna June 9, 2022 13:41
@drashna drashna merged commit d2abfae into qmk:develop Jun 9, 2022
@waffle87 waffle87 deleted the fix/pimoroni_trackball branch June 9, 2022 17:32
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@waffle87 @zykrah
Fixup Pimoroni trackball code (qmk#17335)
cc63a38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waffle87 @daskygit @drashna