Fine!40 PCB Support #17426

Aidan-OS · 2022-06-19T22:25:09Z

Added code for the Fine!40 PCB which is used in the Mochi40 currently in group buy.

Description

The Fine!40 is an Elite-C based PCB with a rotary encoder and an OLED display. The code provided additionally incudes VIA support.

Types of Changes

Issues Fixed or Closed by This PR

None, except for the absolute mess that my last PR was because I apparently started with a very outdated base (among other things).

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This reverts commit 0dd205e.

…lt firmware, the PCB for the Mochi40

Aidan-OS · 2022-06-19T22:26:38Z

Okay, there is a folder here I was sure I removed. I'll fix that.

I'm not entirely sure how this got here again.

keyboards/aidansmithdotdev/fine40/fine40.c

keyboards/aidansmithdotdev/fine40/fine40.h

keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c

keyboards/aidansmithdotdev/fine40/rules.mk

keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c

keyboards/aidansmithdotdev/fine40/info.json

keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c

keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c

Simplified license declaration Co-authored-by: Joel Challis <git@zvecr.com>

Move optional addons to info.json Co-authored-by: Joel Challis <git@zvecr.com>

Move optional addons to info.json

Removing unneeded keymap bloat. Co-authored-by: Joel Challis <git@zvecr.com>

Aidan-OS · 2022-06-19T23:09:14Z

I think everything should be fixed now? It says that there is one change remaining but I don't see it.

drashna · 2022-06-19T23:14:47Z

Please do not close and re-open PRs. Updating the branch on your repo will automatically update the PR. Even if the old PR is master, that's fine. Do it "right", the next time.
#17328

keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c

keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c

Aidan-OS · 2022-06-19T23:21:30Z

@drashna I'm sorry for all the mistakes. I assumed that I should close it because of the master situation.

drashna · 2022-06-19T23:22:23Z

No worries. And git/github is always a learning experience, for sure!

…t in every keymap

Aidan-OS · 2022-06-21T00:23:49Z

Not sure what changes GitHub thinks are left outstanding as I think I have gotten everything now.

keyboards/aidansmithdotdev/fine40/fine40.c

Adding safety check Co-authored-by: Drashna Jaelre <drashna@live.com>

keyboards/aidansmithdotdev/fine40/readme.md

keyboards/aidansmithdotdev/fine40/info.json

Change to a lower quality photo Co-authored-by: Ryan <fauxpark@gmail.com>

…o Fine40

Aidan-OS · 2022-06-22T20:15:45Z

Just wanted to check, is there anything that I have missed?

keyboards/aidansmithdotdev/fine40/readme.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Aidan-OS · 2022-07-05T20:02:34Z

Is that everything?

Aidan-OS · 2022-07-09T06:52:48Z

Is there anything else that is needed?

Aidan-OS · 2022-08-02T20:55:13Z

I don't know how I missed this earlier, but it appears that the Rotary Encoder is no longer functioning with the new setup. I've tried debugging but have no clue what is causing the problem, though I haven't worked with the new method of declaring things in info.json.

Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>

Aidan-OS added 8 commits June 7, 2022 14:51

Updating to Master

0dd205e

Merge branch 'master' of https://github.com/qmk/qmk_firmware

c118c7a

Revert "Updating to Master"

48269c6

This reverts commit 0dd205e.

Added Fineqmk compile -kb handwired/dactyl_manuform_r_track -km defau…

2773817

…lt firmware, the PCB for the Mochi40

Merge branch 'master' of https://github.com/aidan-os/qmk_firmware

d8c41d0

Added fine40 pcb

6b1be42

Updates to the readme

5249f22

Slight changes to layoyut and fixes to readme

4626825

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 19, 2022

Delete keyboards/fine40 directory

4213c39

I'm not entirely sure how this got here again.

zvecr requested changes Jun 19, 2022

View reviewed changes

Aidan-OS and others added 8 commits June 19, 2022 18:55

Update keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c

ff100da

Simplified license declaration Co-authored-by: Joel Challis <git@zvecr.com>

Update keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c

9a78a6f

Simplified license declaration Co-authored-by: Joel Challis <git@zvecr.com>

Update keyboards/aidansmithdotdev/fine40/info.json

1cb4b04

Move optional addons to info.json Co-authored-by: Joel Challis <git@zvecr.com>

Update keyboards/aidansmithdotdev/fine40/rules.mk

8de7a32

Move optional addons to info.json Co-authored-by: Joel Challis <git@zvecr.com>

Delete fine40.h

41ea419

Move optional addons to info.json

Delete fine40.c

6e56010

Move optional addons to info.json

Update keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c

69698a3

Removing unneeded keymap bloat. Co-authored-by: Joel Challis <git@zvecr.com>

Update keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c

8ee54a5

Removing unneeded keymap bloat. Co-authored-by: Joel Challis <git@zvecr.com>

drashna reviewed Jun 19, 2022

View reviewed changes

keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c Outdated Show resolved Hide resolved

keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c Outdated Show resolved Hide resolved

Moving OLED and Encoder code to a general file instead of including i…

481c7b9

…t in every keymap

drashna requested changes Jun 21, 2022

View reviewed changes

keyboards/aidansmithdotdev/fine40/fine40.c Show resolved Hide resolved

keyboards/aidansmithdotdev/fine40/fine40.c Show resolved Hide resolved

Apply suggestions from code review

67ee00a

Adding safety check Co-authored-by: Drashna Jaelre <drashna@live.com>

drashna approved these changes Jun 21, 2022

View reviewed changes

drashna requested a review from a team June 21, 2022 01:57

fauxpark requested changes Jun 21, 2022

View reviewed changes

keyboards/aidansmithdotdev/fine40/readme.md Outdated Show resolved Hide resolved

keyboards/aidansmithdotdev/fine40/info.json Outdated Show resolved Hide resolved

Aidan-OS and others added 3 commits June 20, 2022 23:22

Update keyboards/aidansmithdotdev/fine40/readme.md

280af16

Change to a lower quality photo Co-authored-by: Ryan <fauxpark@gmail.com>

Removed mixes of spaces and tabs

c423dd1

Merge branch 'Fine40' of https://github.com/aidan-os/qmk_firmware int…

7db9c85

…o Fine40

fauxpark requested changes Jun 22, 2022

View reviewed changes

keyboards/aidansmithdotdev/fine40/readme.md Outdated Show resolved Hide resolved

Update keyboards/aidansmithdotdev/fine40/readme.md

3c11b21

Co-authored-by: Ryan <fauxpark@gmail.com>

fauxpark approved these changes Jul 9, 2022

View reviewed changes

drashna merged commit 7a73f9a into qmk:develop Jul 11, 2022

Aidan-OS mentioned this pull request Nov 4, 2022

Added fine40 json (for Mochi40) the-via/keyboards#1516

Merged

6 tasks

Uh oh!

Fine!40 PCB Support #17426

Fine!40 PCB Support #17426

Uh oh!

Conversation

Aidan-OS commented Jun 19, 2022

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Uh oh!

Aidan-OS commented Jun 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aidan-OS commented Jun 19, 2022

Uh oh!

drashna commented Jun 19, 2022

Uh oh!

Uh oh!

Uh oh!

Aidan-OS commented Jun 19, 2022

Uh oh!

drashna commented Jun 19, 2022

Uh oh!

Aidan-OS commented Jun 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aidan-OS commented Jun 22, 2022

Uh oh!

Uh oh!

Aidan-OS commented Jul 5, 2022

Uh oh!

Aidan-OS commented Jul 9, 2022

Uh oh!

Aidan-OS commented Aug 2, 2022

Uh oh!

Uh oh!