Skip to content

ISSI Drivers Global Current Option #17448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

ISSI Drivers Global Current Option #17448

merged 1 commit into from
Jun 23, 2022

Conversation

Electro707
Copy link
Contributor

@Electro707 Electro707 commented Jun 21, 2022 •
edited
Loading

Description

This PR, in relation with #17420, adds the ISSI_GLOBALCURRENT setting to all other ISSI drivers that support that current have it hardcoded.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Electro707 Electro707 changed the base branch from master to develop June 21, 2022 23:29
@github-actions github-actions bot added core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels Jun 21, 2022
@Electro707
Copy link
Contributor Author

Also I noticed that some ISSI drivers don't have documentation in feature_rgb_matrix.md. Should I add them in this PR, or is there a reason they aren't documented?

@drashna
Copy link
Member

drashna commented Jun 22, 2022

Also I noticed that some ISSI drivers don't have documentation in feature_rgb_matrix.md. Should I add them in this PR, or is there a reason they aren't documented?

They should be documented, but as a separate PR. Eg, don't want to do a bunch of different things in one PR, if it can be helped.

@drashna drashna requested a review from a team June 22, 2022 00:58
@zvecr zvecr merged commit d385858 into qmk:develop Jun 23, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@Electro707 @zykrah
Added global current to all other issi drivers who don't have it (qmk…
8c883ba 
…#17448)
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Electro707 @nolanseaton
Added global current to all other issi drivers who don't have it (qmk…
3952936 
…#17448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Electro707 @drashna @zvecr