-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
[Core] STM32_USB_USE_OTG1 => USB_ENDPOINTS_ARE_REORDERABLE
#17647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
STM32_USB_USE_OTG1 => USB_HAS_BIDIRECTIONAL_ENDPOINTSSTM32_USB_USE_OTG1 => USB_ENDPOINTS_ARE_REORDERABLE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the endpoint initialization code usb_main.c:
.inout_ep_config = \
{ \
stream##_IN_MODE, /* Interrupt EP */ \
NULL, /* SETUP packet notification callback */ \
qmkusbDataTransmitted, /* IN notification callback */ \
qmkusbDataReceived, /* OUT notification callback */ \
stream##_EPSIZE, /* IN maximum packet size */ \
stream##_EPSIZE, /* OUT maximum packet size */ \
NULL, /* IN Endpoint state */ \
NULL, /* OUT endpoint state */ \
2, /* IN multiplier */ \
NULL /* SETUP buffer (not a SETUP endpoint) */ \
}, \the vendor usb lld driver specific part
2, /* IN multiplier */ \
NULL /* SETUP buffer (not a SETUP endpoint) */ should be replaced with usb_lld_endpoint_fields define so it can be reusable for e.g. RP2040. (though I have to confirm that it works on that chip).
|
Curiosity got the better of me: It is just two places usb_patch.txt but RP2040 sadly won't boot up. But doesn't really matter either with 32 endpoints available. |
57de830 to
ffa6abb
Compare
ffa6abb to
4ae5db8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making it mcu independent.
Description
Creates a new define --
USB_ENDPOINTS_ARE_REORDERABLE-- which decouples bidirectional endpoints from the previously-(ab)usedSTM32_USB_USE_OTG1.Also fixes
make <kb>:<km>:dump_vars.SHA1's match when comparing builds:
Types of Changes
Checklist