Skip to content

Add tap_code16_delay #17748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2022
Merged

Add tap_code16_delay #17748

merged 1 commit into from
Jul 23, 2022
+18 −6

Conversation

JayceFayne
Copy link
Contributor

@JayceFayne JayceFayne commented Jul 22, 2022 •
edited
Loading

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 22, 2022
@JayceFayne JayceFayne force-pushed the tap_code16_delay branch 3 times, most recently from 8bf87d5 to 0a6a507 Compare July 22, 2022 07:59
@zvecr zvecr changed the base branch from master to develop July 22, 2022 13:03
zvecr
zvecr requested changes Jul 22, 2022
View reviewed changes
@JayceFayne JayceFayne force-pushed the tap_code16_delay branch 2 times, most recently from 90f54cc to 3db6edb Compare July 22, 2022 13:23
@zvecr
implement tap_code16_delay
f311526 
Co-authored-by: Joel Challis <git@zvecr.com>
@JayceFayne JayceFayne requested a review from zvecr July 22, 2022 14:09
@drashna drashna requested a review from a team July 22, 2022 21:12
@zvecr zvecr merged commit d02cefe into qmk:develop Jul 23, 2022
@JayceFayne JayceFayne deleted the tap_code16_delay branch July 24, 2022 11:46
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@JayceFayne @nolanseaton
implement tap_code16_delay (qmk#17748)
a260790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JayceFayne @drashna @zvecr