[Core] guard RPC invocation by checking RPC info against crc checksum #17840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the RPC info data was corrupted during transmission we prevent the execution of bogus data.
KarlK90
changed the title
daskygit
approved these changes
Jul 29, 2022
|
@tzarc I would like to have your opinion on this implementation as well before merging, as you wrote and designed the system in the first place. |
drashna
approved these changes
Jul 29, 2022
tzarc
approved these changes
Aug 6, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case the RPC info data was corrupted during transmission we prevent the execution of bogus data.
Types of Changes
Issues Fixed or Closed by This PR
Checklist