Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TAP_CODE_DELAY for encoder mapping by default. Add docs. #18098

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Use TAP_CODE_DELAY for encoder mapping by default. Add docs. #18098

merged 1 commit into from
Aug 29, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 18, 2022

Description

Use TAP_CODE_DELAY for encoder mapping by default. Add docs for ENCODER_MAP_KEY_DELAY in case someone wants different values.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team August 18, 2022 23:41
@drashna drashna merged commit d910e8d into qmk:develop Aug 29, 2022
@tzarc tzarc deleted the encoder-map-delay branch September 18, 2022 21:37
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
Use TAP_CODE_DELAY for encoder mapping by default (qmk#18098)
6f263d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tzarc @fauxpark @zvecr @drashna