Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject json with duplicate keys #18108

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Reject json with duplicate keys #18108

merged 1 commit into from
Nov 9, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 19, 2022 •
edited

Description

All duplicates have now been refactored, such as keyboard aliases.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the base branch from master to develop August 19, 2022 19:25
@zvecr zvecr changed the title Feature/validate duplicate keys @zvecr Reject json with duplicate keys? Aug 19, 2022
@zvecr zvecr changed the title @zvecr Reject json with duplicate keys? Reject json with duplicate keys? Aug 19, 2022
@zvecr zvecr force-pushed the feature/validate_duplicate_keys branch from b737202 to b0d93d5 Compare October 29, 2022 23:28
@github-actions github-actions bot added cli qmk cli command python and removed CI core labels Oct 29, 2022
@zvecr zvecr force-pushed the feature/validate_duplicate_keys branch from b0d93d5 to 8cf9ae7 Compare October 29, 2022 23:29
@zvecr zvecr mentioned this pull request Nov 9, 2022
Merged
14 tasks
@zvecr zvecr force-pushed the feature/validate_duplicate_keys branch from 8cf9ae7 to aa56431 Compare November 9, 2022 15:10
@zvecr zvecr marked this pull request as ready for review November 9, 2022 15:11
@zvecr zvecr requested a review from a team November 9, 2022 15:12
@zvecr zvecr changed the title Reject json with duplicate keys? Reject json with duplicate keys Nov 9, 2022
@zvecr zvecr requested a review from fauxpark November 9, 2022 15:13
@zvecr zvecr merged commit dc91624 into qmk:develop Nov 9, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Reject json with duplicate keys? (qmk#18108)
3a1b8d5
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Reject json with duplicate keys? (qmk#18108)
d785c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @fauxpark