mcp23018: add return status to init #18178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohSchneider
force-pushed
the
mcp23018
branch
2 times, most recently
from
25e3076
to
25ac370
Compare
include a "is the device actually connected?" check into the init function, that now returns a boolean, which can be handled by a keyboard to - for example - decide not to query an unconnected portexpander during each matrix scan; avoiding i2c spam/errors/timeouts Signed-off-by: Johannes Schneider <JohSchneider@googlemail.com>
drashna
approved these changes
Oct 10, 2022
fauxpark
approved these changes
Oct 10, 2022
14 tasks
zvecr
added a commit
that referenced
this pull request
Oct 29, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include a "is the device actually connected?" check into the init
function, that now returns a boolean, which can be handled by a
keyboard to - for example - decide not to query an unconnected
portexpander during each matrix scan; avoiding i2c
spam/errors/timeouts
Signed-off-by: Johannes Schneider JohSchneider@googlemail.com
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist