Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over MANUFACTURER and PRODUCT to string literals #18183

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Switch over MANUFACTURER and PRODUCT to string literals #18183

merged 2 commits into from
Aug 28, 2022

Conversation

fauxpark
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 28, 2022 05:23
@drashna drashna merged commit d983251 into qmk:develop Aug 28, 2022
@fauxpark fauxpark deleted the manu-product-string-literals branch August 28, 2022 17:01
This was referenced Aug 28, 2022
Merged
Merged
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Switch over MANUFACTURER and PRODUCT to string literals (qmk#18183)
29c76da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core documentation enhancement keyboard keymap python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fauxpark @drashna @tzarc @zvecr