Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromeos keycodes #18212

Merged
merged 3 commits into from
Sep 17, 2022
Merged

Chromeos keycodes #18212

merged 3 commits into from
Sep 17, 2022

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Aug 29, 2022

Description

Adds keycodes for HID Consumer Page AL Control Panel (0x19F) and AL Assistant (0x1CB), which are used by ChromeOS devices (Chromebooks have dedicated keys that emit these codes).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@spidey3 spidey3 requested a review from fauxpark August 29, 2022 22:57
@zvecr zvecr changed the base branch from master to develop August 29, 2022 23:45
@spidey3 spidey3 requested a review from a team August 30, 2022 00:04
@spidey3
Copy link
Contributor Author

spidey3 commented Aug 30, 2022

Rebased to develop, since it's now targeted there.

@tzarc tzarc merged commit a26f1dd into qmk:develop Sep 17, 2022
@spidey3 spidey3 deleted the chromeos_keycodes branch September 17, 2022 19:29
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@spidey3 @ramonimbao
Chromeos keycodes (qmk#18212)
a40104b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spidey3 @tzarc @fauxpark