Add pointing device support to data driven config #18215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlK90
requested changes
Aug 30, 2022
zvecr
reviewed
Aug 30, 2022
zvecr
reviewed
Aug 30, 2022
drashna
force-pushed
the
dd/pointing_device
branch
from
ed133c8
to
3dfd539
Compare
Kriechi
reviewed
Sep 3, 2022
data/mappings/info_config.json
Outdated
| @@ -92,6 +103,7 @@ | |||
| "SECURE_IDLE_TIMEOUT": {"info_key": "secure.idle_timeout", "value_type": "int"}, | |||
| "SENDSTRING_BELL": {"info_key": "audio.macro_beep", "value_type": "bool"}, | |||
| "SPLIT_MODS_ENABLE": {"info_key": "split.transport.sync_modifiers", "value_type": "bool"}, | |||
| "SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"}, | |||
There was a problem hiding this comment.
I expected this to fit into the transport options - or how would you distinguish these here?
There was a problem hiding this comment.
ah, fair.
Suggested change
| "SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"}, | |
| "SPLIT_POINTING_ENABLE": {"info_key": "split.transport.sync_pointing", "value_type": "bool"}, |
There was a problem hiding this comment.
split.transport.sync_pointing_device ?
though I'm not sure what is actually synced - but all other options use _DEVICE_ as part of the name.
There was a problem hiding this comment.
Honestly, I'm horrible at naming...
Not sure if it's better to use the full "pointing device" as per the other features, or keep it closer to what the other transport.sync_* names are for consistency (with both naming in the info.json and config.h stuff)
Kriechi
reviewed
Sep 25, 2022
Kriechi
reviewed
Sep 25, 2022
drashna
force-pushed
the
dd/pointing_device
branch
from
d4ddf5d
to
a8b8679
Compare
fauxpark
requested changes
Sep 26, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
drashna
force-pushed
the
dd/pointing_device
branch
from
6ad0fd1
to
78619e5
Compare
tzarc
approved these changes
Nov 13, 2022
drashna
added a commit
to drashna/qmk_firmware
that referenced
this pull request
Nov 13, 2022
This reverts commit d3073ef.
tzarc
pushed a commit
that referenced
this pull request
Nov 15, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
Co-authored-by: Joel Challis <git@zvecr.com>
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
14 tasks
Kriechi
pushed a commit
to Kriechi/qmk_firmware
that referenced
this pull request
Apr 17, 2023
resurrected and squashed from qmk#18215
Kriechi
pushed a commit
to Kriechi/qmk_firmware
that referenced
this pull request
Aug 17, 2023
resurrected and squashed from qmk#18215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First attempt at adding support for data driven config.
Types of Changes
Checklist