Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bootloader.mk to platforms #18228

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

fauxpark
Copy link
Member

Description

At this point every keyboard should have either a valid bootloader set, or custom. Anything else should generate an error.

This change splits up bootloader.mk into platform-specific makefiles, to further lock out anything that is invalid (eg. md-boot for atmega32u4). This would fail to compile anyway as there is no md-boot.c under the AVR bootloaders directory, but now it should spit out a more user friendly error.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 31, 2022 05:19
@fauxpark
Copy link
Member Author

 ☒ handwired/pytest/has_community: Can't find default keymap.

This lint error is unrelated. This board indeed has no keymaps at all; the intention I guess is to test community layout support. Not sure whether anything can/should be done about it.

@fauxpark fauxpark marked this pull request as ready for review August 31, 2022 06:09
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drashna drashna merged commit bb6f028 into qmk:develop Aug 31, 2022
@fauxpark fauxpark deleted the bootloader-selection-to-platforms branch August 31, 2022 14:24
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants