Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all keyboards have a bootloader set #18234

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

fauxpark
Copy link
Member

Description

As a result of #18228 removing the default bootloader assignment and adjusting the makefile logic to complain if no bootloader is set, or an invalid one for the given platform:

Failing builds:
  clueboard/17:default
  clueboard/66/rev1:default
  clueboard/66/rev1:via
  clueboard/66/rev2:default
  clueboard/66/rev2:via
  clueboard/66/rev3:default
  clueboard/66/rev3:via
  clueboard/66_hotswap/prototype:default
  clueboard/card:default
  handwired/3dortho14u/rev1:default
  handwired/3dortho14u/rev1:via
  handwired/3dortho14u/rev2:default
  handwired/3dortho14u/rev2:via
  handwired/dactyl_manuform/4x5_5:default
  handwired/dactyl_manuform/dmote/62key:default
  handwired/hillside/46:default
  handwired/hillside/46:via
  handwired/hillside/48:default
  handwired/hillside/48:via
  handwired/hillside/52:default
  handwired/hillside/52:via
  handwired/wakizashi40:default
  handwired/wakizashi40:via
  lfkeyboards/lfk65_hs:default

I was worried there'd be much more, honestly.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 31, 2022 15:36
@zvecr zvecr merged commit 50c4ca3 into qmk:develop Aug 31, 2022
@fauxpark fauxpark deleted the add-missing-bootloaders branch August 31, 2022 16:37
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants