Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around WinCompose issue for U+Axxx or U+Exxx #18260

Merged
merged 2 commits into from
Sep 18, 2022
Merged

Work around WinCompose issue for U+Axxx or U+Exxx #18260

merged 2 commits into from
Sep 18, 2022

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Sep 3, 2022 •
edited

Description

AtlasTheGarbage said:

btw one of the biggest bugs involving unicode input (which QMK relies on) is still unpatched
where anything U+Axxx or U+Exxx is not accessible due to the sequences for Ă/ă/Ĕ/ĕ

This works around that problem by prepending a 0 in UC_WINC if the code begins with A-F, as the problem does not occur if a leading zero is added (U+0Axxx or U+0Exxx).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 3, 2022
@spidey3
Copy link
Contributor Author

spidey3 commented Sep 3, 2022 •
edited

I don't have a Windows machine handy to test this, but in theory it should work.
It's verified not to break Linux and Mac.
Help testing would be appreciated!

@spidey3 spidey3 marked this pull request as ready for review September 4, 2022 16:44
@spidey3 spidey3 requested a review from sigprof September 4, 2022 22:10
@spidey3 spidey3 changed the base branch from master to develop September 12, 2022 18:57
@spidey3
Copy link
Contributor Author

spidey3 commented Sep 12, 2022

I've rebased and re-pointed this at the develop branch.

@drashna
Copy link
Member

drashna commented Sep 14, 2022

I can see about testing this on a windows machine this week

@spidey3
Copy link
Contributor Author

spidey3 commented Sep 17, 2022

I've picked up @tzarc's suggested simplification.

@spidey3 spidey3 merged commit a3a47a6 into qmk:develop Sep 18, 2022
@spidey3 spidey3 deleted the winc_unicode_workaround branch September 18, 2022 15:51
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@spidey3 @preisi @ramonimbao
Work around WinCompose issue for U+Axxx or U+Exxx (qmk#18260)
db25f90 
* Work around WinCompose issue for U+Axxx or U+Exxx

* tzarc's more efficient version

Co-authored-by: Thomas <mail@tpreisner.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

@sigprof sigprof Awaiting requested review from sigprof

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
core help wanted needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spidey3 @drashna @sigprof @tzarc @zvecr @preisi