Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated RESET keycode alias #18271

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Remove deprecated RESET keycode alias #18271

merged 1 commit into from
Sep 14, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 5, 2022 •
edited

Description

_Static_assert currently cannot be added as it throws errors where the previous RESET bodges were required.

However, limiting legacy keycodes to only files where QMK_KEYBOARD_H is used makes it slightly happy. Mocked up in 2cbf950c6ea1ce8ae6ff5efa68e8c2add367fba9.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 5, 2022
@zvecr zvecr marked this pull request as ready for review September 5, 2022 21:33
@zvecr zvecr requested a review from a team September 5, 2022 21:33
@drashna drashna merged commit 8d715fc into qmk:develop Sep 14, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Remove deprecated RESET keycode alias (qmk#18271)
a16f9af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @fauxpark