Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy define USE_SERIAL_PD2 #18298

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Remove legacy define USE_SERIAL_PD2 #18298

merged 1 commit into from
Sep 6, 2022

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Sep 6, 2022

Description

Little smaller than the last

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 6, 2022
@zvecr zvecr merged commit c2b35b2 into qmk:develop Sep 6, 2022
@daskygit daskygit deleted the pr/remove_pd2 branch September 6, 2022 23:54
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@daskygit @ramonimbao
Remove legacy define USE_SERIAL_PD2 (qmk#18298)
b6a9d19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daskygit @zvecr