Add Elite-C to converters #18309
Merged
Add Elite-C to converters #18309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Sep 8, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
zvecr
force-pushed
the
feature/elite_c_to_stemcell
branch
from
1b1c3ed
to
42deeb8
Compare
tzarc
approved these changes
Sep 17, 2022
nooges
approved these changes
Sep 18, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
ryanbaekr
reviewed
Dec 13, 2022
| #define B5 9U | ||
|
|
||
| // Right side (front) | ||
| // RAW |
There was a problem hiding this comment.
This is not RAW on Elite-C, it is B0. Can B0 be mapped to 10U or 11U so that the converter can at least succeed on boards that use B0 on Elite-C? Even if it means the user has to jump the pin...
ryanbaekr
reviewed
Dec 13, 2022
| #define B5 PAL_LINE(GPIOB, 9) | ||
|
|
||
| // Right side (front) | ||
| // RAW |
There was a problem hiding this comment.
You have the same issue here. This is not RAW on Elite-C. The converter will not succeed on boards that use B0
ryanbaekr
reviewed
Dec 13, 2022
| | Pinout | Notes | | ||
| |------------|-----------------------------------| | ||
| | `promicro` | Includes RX/TX LEDs | | ||
| | `elite_c` | Includes bottom row pins, no LEDs | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#18239 broke conversions which incorrectly relied on Elite-C pinouts for Pro Micro converters.
Future iteration
Potentially reduce duplication by inferring
promicrocompatibility when targetingelite_c.Types of Changes
Issues Fixed or Closed by This PR
Checklist