Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reboot wb32 devices after flashing #18323

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Reboot wb32 devices after flashing #18323

merged 1 commit into from
Sep 10, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 9, 2022 •
edited

Description

-D and -R at the same time doesnt seem to function, so run them back-to-back.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 9, 2022
@zvecr zvecr requested a review from a team September 9, 2022 22:35
spidey3
spidey3 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spidey3 spidey3 requested a review from a team September 9, 2022 22:50
@zvecr zvecr merged commit 4087251 into qmk:develop Sep 10, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Reboot wb32 devices after flashing (qmk#18323)
95af2a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @spidey3