Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining use of terminal keys and related comment labels #18402

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Remove remaining use of terminal keys and related comment labels #18402

merged 1 commit into from
Sep 30, 2022

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented Sep 18, 2022

Description

The terminal feature was removed in 8545473 (Removes terminal from QMK. (#17258), 2022-05-31). This commit removes the remaining usages of TERM_{ON,OFF} and removes the terminal key labels from the keymap comments where the keymap itself had already been updated.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 18, 2022
fauxpark
fauxpark requested changes Sep 18, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this touches user keymaps this will need to go through develop.

@tzarc tzarc changed the base branch from master to develop September 18, 2022 12:49
@kyrias
Copy link
Contributor Author

kyrias commented Sep 18, 2022

Rebased on develop now. Maybe this is something that should be added to the PR Checklist. :)

@drashna
Copy link
Member

drashna commented Sep 24, 2022

This has a merge conflict.

@kyrias
Remove remaining use of terminal keys and related comment labels
79edfea 
The terminal feature was removed in 8545473 (Removes terminal from
QMK. (qmk#17258), 2022-05-31).  This commit removes the remaining usages of
`TERM_{ON,OFF}` and removes the terminal key labels from the keymap
comments.
@kyrias
Copy link
Contributor Author

kyrias commented Sep 24, 2022

Rebased again.

@drashna drashna merged commit d412dc6 into qmk:develop Sep 30, 2022
@kyrias kyrias deleted the remove-remaining-term-usage branch September 30, 2022 12:50
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@kyrias @ramonimbao
Remove remaining use of terminal keys and related comment labels (qmk…
af829f8 
…#18402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyrias @drashna @fauxpark