Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change {LED,RGB}_DISABLE_TIMEOUT to {LED,RGB}_MATRIX_TIMEOUT #18415

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Change {LED,RGB}_DISABLE_TIMEOUT to {LED,RGB}_MATRIX_TIMEOUT #18415

merged 5 commits into from
Sep 26, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 19, 2022 •
edited

Description

Removing deprecated {LED,RGB}_DISABLE_AFTER_TIMEOUT in favour of {LED,RGB}_DISABLE_TIMEOUT -> {LED,RGB}_MATRIX_TIMEOUT.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Sep 19, 2022
@fauxpark fauxpark requested a review from a team September 19, 2022 07:25
spidey3
spidey3 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna
Copy link
Member

drashna commented Sep 24, 2022

has some merge conflicts

@fauxpark fauxpark merged commit ea2819b into qmk:develop Sep 26, 2022
@fauxpark fauxpark deleted the led-rgb-matrix-dd-timeout branch September 26, 2022 04:40
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Change {LED,RGB}_DISABLE_TIMEOUT to {LED,RGB}_MATRIX_TIMEOUT (qmk…
60a26f3 
…#18415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@spidey3 spidey3 spidey3 approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @drashna @spidey3