Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] remove busy waiting from rgblight functions #18418

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Sep 19, 2022

Description

Remove busy waiting from rgblight functions these have presumably been added to guarantee ws2812 leds being reset properly, but this is already handled by the low level ws2812 drivers. Therefore we remove these waits to not block the main thread.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 19, 2022
@KarlK90 KarlK90 requested a review from a team September 19, 2022 13:25
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wait.h include can likely be removed.

...these have presumably been added to guarantee ws2812 leds being reset
properly, but this is already handled by the low level ws2812 drivers.
Therefore we remove these waits to not block the main thread.
@KarlK90 KarlK90 force-pushed the fix/remove-busy-waiting-from-rgblight branch from f54ca64 to 3f71914 Compare September 19, 2022 15:52
@KarlK90
Copy link
Member Author

KarlK90 commented Sep 19, 2022

removed the wait.h include

@KarlK90 KarlK90 merged commit 2aa3a8e into qmk:develop Sep 19, 2022
@KarlK90 KarlK90 deleted the fix/remove-busy-waiting-from-rgblight branch September 19, 2022 16:05
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants