[Bug] Update Chibios to latest 21.11.2 changes for RP2040 XIP deadlock mitigation #18428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a hotfix for RP2040 deadlocks due to XIP cache misses in the ChibiOS virtual timer implementation.
|
CC: @xyzz |
|
We generally don't accept submodule changes directly to master. The issue isn't just with the scope of the changes to code, but includes the mess we get on discord where users have incorrectly commited submodule updates (most visible in PRs where it gets the "dependencies" label). |
|
Alright thanks for the explanation. Currently the bug mostly manifested in the VIAL fork but might hit users of mainline QMK as well in the future. Anyway those users can use |
drashna
approved these changes
Sep 19, 2022
zvecr
approved these changes
Sep 20, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
This includes a hotfix for RP2040 deadlocks due to XIP cache misses in the ChibiOS virtual timer implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes a hotfix for RP2040 deadlocks due to XIP cache misses in the ChibiOS virtual timer implementation. The change set is minimal and should be safe to apply to the
masterbranch. Also includes an ELF driver for the missing STM32F4s - so we can get rid of the legacy implementations.Types of Changes
Issues Fixed or Closed by This PR
Checklist