Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise info_config.h define generation #18439

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Normalise info_config.h define generation #18439

merged 4 commits into from
Sep 21, 2022

Conversation

fauxpark
Copy link
Member

Description

Wrap the boilerplate ifndef...define...endif in its own reusable function.

Ran into this while looking at automating DD RGBLight & LED/RGB Matrix animations (as opposed to adding mappings for each effect in info_config.json).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 21, 2022 10:36
tzarc
tzarc requested changes Sep 21, 2022
View reviewed changes
lib/python/qmk/cli/generate/config_h.py Outdated Show resolved Hide resolved
@fauxpark @tzarc
Update lib/python/qmk/cli/generate/config_h.py
41f9673 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@zvecr zvecr merged commit 2f48d30 into qmk:develop Sep 21, 2022
@fauxpark fauxpark deleted the normalise-info-config-h branch September 21, 2022 17:35
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @tzarc @ramonimbao
Normalise info_config.h define generation (qmk#18439)
4feb91f 
* Normalise info_config.h define generation

* format

* Fix tests

* Update lib/python/qmk/cli/generate/config_h.py

Co-authored-by: Nick Brassel <nick@tzarc.org>

Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @tzarc @zvecr