Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start moving towards introspection-based data retrieval #18441

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Start moving towards introspection-based data retrieval #18441

merged 3 commits into from
Sep 29, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Sep 21, 2022 •
edited

Description

Starts preparation for decoupling dynamic keymap from being so intertwined with EEPROM as its specific backend.
Adds overridable functions for retrieval of keymap and encodermap data.
Modified dynamic_keymap.c to implement those overrides, allowing normal use of keymap_key_to_keycode.

Combos, key overrides, etc. to come in followup PRs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team September 21, 2022 11:29
@github-actions github-actions bot added the core label Sep 21, 2022
@tzarc tzarc marked this pull request as ready for review September 21, 2022 12:22
@drashna drashna requested a review from a team September 24, 2022 16:13
@zvecr zvecr merged commit cbbb45c into qmk:develop Sep 29, 2022
@tzarc tzarc deleted the keymap_introspection branch September 29, 2022 23:10
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
Start moving towards introspection-based data retrieval (qmk#18441)
9536c24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzarc @drashna @zvecr