Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup controllerworks/mini42 #18553

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Fixup controllerworks/mini42 #18553

merged 2 commits into from
Sep 30, 2022

Conversation

waffle87
Copy link
Member

Description

DRIVER_LED_TOTAL -> RGB_MATRIX_LED_COUNT & misc cleanup

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 30, 2022 21:15
keyboard-magpie
keyboard-magpie approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed all this first time round :(

@keyboard-magpie keyboard-magpie merged commit d1903f4 into qmk:develop Sep 30, 2022
@waffle87 waffle87 deleted the fix/mini42 branch September 30, 2022 22:06
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Fixup controllerworks/mini42 (qmk#18553)
dc17ba3 
fix up stuff by waffle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waffle87 @fauxpark @keyboard-magpie